-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(auth)!: move consent interaction to different port #2665
feat(auth)!: move consent interaction to different port #2665
Conversation
✅ Deploy Preview for brilliant-pasca-3e80ec ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
a239a55
to
55effbf
Compare
55effbf
to
4a82474
Compare
09f76e1
to
3d169e6
Compare
packages/documentation/src/content/docs/concepts/open-payments/grant-interaction.mdx
Show resolved
Hide resolved
const acceptResponse = await fetch( | ||
`${url.toString()}grant/${interactId}/${nonce}/accept`, | ||
`${deps.sendingASE.config.interactionServer}/grant/${interactId}/${nonce}/accept`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
final thing, I think we just need to expose interactionServer
on the TestConfig
interface
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me check that. I also need to rebase to main
a512b22
to
c0fb04c
Compare
Accept and reject interaction choices should not be exposed. but other routes can and must be exposed. This is why we need to move the choice routes to different port BREAKING CHANGE: Routes for accepting and rejecting choice are no longer exposed. Ideally, this must be done through ASE backend service that checks for authentication / authorization
Co-authored-by: Max Kurapov <max@interledger.org>
ecd799b
to
4135dfa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very last thing
4135dfa
to
7461f68
Compare
Changes proposed in this pull request
Context
fixes #2649
Checklist
fixes #number